Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Matthews_correlation_coefficient #320

Closed
del2z opened this issue Jun 26, 2021 · 2 comments · Fixed by #321
Closed

Bug in Matthews_correlation_coefficient #320

del2z opened this issue Jun 26, 2021 · 2 comments · Fixed by #321
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Milestone

Comments

@del2z
Copy link

del2z commented Jun 26, 2021

I've tested the ConfusionMatrix and got results similar to the one in https://en.wikipedia.org/wiki/Matthews_correlation_coefficient. However, the code in line 23 is incorrect according to the confusion matrix.
tk, defined as the number of times class k truly occurred, should be the summation along axis=1; pk, on the other hand, is the summation of confusion matrix along axis=0.
Although this mistake does not affect the final result of Matthews correlation coefficient, it may lead to some misunderstanding of the confusion matrix. Hope it can be fixed.

@del2z del2z added bug / fix Something isn't working help wanted Extra attention is needed labels Jun 26, 2021
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@SkafteNicki
Copy link
Member

@del2z Thanks for bringing this to our attention. I created PR #321 to fix this.

@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants