Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude thresholds of 0.0 and 1.0 in precision recall curve #265

Closed
jacanchaplais opened this issue May 28, 2021 · 2 comments · Fixed by #322
Closed

Exclude thresholds of 0.0 and 1.0 in precision recall curve #265

jacanchaplais opened this issue May 28, 2021 · 2 comments · Fixed by #322
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jacanchaplais
Copy link

🚀 Feature

Instead of using threshold values in the inclusive range [0, 1], it would be good to have (at least the option for) thresholds in the exclusive range (0, 1). Custom threshold values would be even better, in my opinion.

Motivation

I am tracking metrics for memory intensive models, and don't want to keep track of values which are not useful. Also, it clutters up my TensorBoard, which is mildly annoying.

Pitch

I guess you could just add in an optional boolean argument like

def BinnedPrecisionRecallCurve(..., exclusive: bool = False):
    ...

to exclude the edge values.

Alternatives

If you wanted to allow user specified thresholds, which I would prefer but might be confusing with "binned" being part of the name, perhaps you could allow:

pr = BinnedPrecisionRecallCurve(num_thresholds=None, thresholds=[0.1, 0.5, 0.9], ...)
@jacanchaplais jacanchaplais added enhancement New feature or request help wanted Extra attention is needed labels May 28, 2021
@SkafteNicki
Copy link
Member

@maximsch2 any opinion here?

@maximsch2
Copy link
Contributor

maximsch2 commented May 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants