Skip to content

Commit

Permalink
Skip matrix test + unpin pandas due to numpy mismatch
Browse files Browse the repository at this point in the history
  • Loading branch information
stancld committed Nov 13, 2022
1 parent feb1f71 commit c23b0de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion requirements/nominal_test.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pandas>=1.2.5
pandas # cannot pin version due to numpy version incompatibility
dython # todo: pin version, but some version resolution issue
3 changes: 3 additions & 0 deletions tests/unittests/nominal/test_cramers.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ def test_cramers_v_differentiability(self, preds, target, bias_correction, nan_s
@pytest.mark.skipif(
_compare_version("pandas", operator.lt, "1.3.2"), reason="`dython` package requires `pandas>=1.3.2`"
)
@pytest.mark.skipif( # TODO: testing on CUDA fails with pandas 1.3.5, and newer is not available for python 3.7
torch.cuda.is_available(), reason="Tests fail on CUDA with the most up-to-date available pandas"
)
@pytest.mark.parametrize("bias_correction", [False, True])
@pytest.mark.parametrize("nan_strategy, nan_replace_value", [("replace", 1.0), ("drop", None)])
def test_cramers_v_matrix(_matrix_input, bias_correction, nan_strategy, nan_replace_value):
Expand Down

0 comments on commit c23b0de

Please sign in to comment.