Fix metric collection missing update of property (#1052)

CHANGELOG.md

@@ -78,6 +78,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed default value for `mdmc_average` in `Accuracy` ([#1036](https://github.com/PyTorchLightning/metrics/pull/1036))
 
 
+- Fixed missing copy of property when using compute groups in `MetricCollection` ([#1052](https://github.com/PyTorchLightning/metrics/pull/1052))
+
+
 ## [0.8.2] - 2022-05-06
 
 

tests/bases/test_collections.py

@@ -340,25 +340,35 @@ def test_check_compute_groups(metrics, expected, prefix, postfix):
     assert len(m.compute_groups) == len(m)
     assert m2.compute_groups == {}
 
-    preds = torch.randn(10, 3).softmax(dim=-1)
-    target = torch.randint(3, (10,))
-    m.update(preds, target)
-    m2.update(preds, target)
+    for _ in range(2):  # repeat to emulate effect of multiple epochs
+        preds = torch.randn(10, 3).softmax(dim=-1)
+        target = torch.randint(3, (10,))
+        m.update(preds, target)
+        m2.update(preds, target)
 
-    assert m.compute_groups == expected
-    assert m2.compute_groups == {}
+        for _, member in m.items():
+            assert member._update_called
 
-    preds = torch.randn(10, 3).softmax(dim=-1)
-    target = torch.randint(3, (10,))
-    # compute groups should kick in here
-    m.update(preds, target)
-    m2.update(preds, target)
+        assert m.compute_groups == expected
+        assert m2.compute_groups == {}
+
+        preds = torch.randn(10, 3).softmax(dim=-1)
+        target = torch.randint(3, (10,))
+        # compute groups should kick in here
+        m.update(preds, target)
+        m2.update(preds, target)
+
+        for _, member in m.items():
+            assert member._update_called
+
+        # compare results for correctness
+        res_cg = m.compute()
+        res_without_cg = m2.compute()
+        for key in res_cg.keys():
+            assert torch.allclose(res_cg[key], res_without_cg[key])
 
-    # compare results for correctness
-    res_cg = m.compute()
-    res_without_cg = m2.compute()
-    for key in res_cg.keys():
-        assert torch.allclose(res_cg[key], res_without_cg[key])
+        m.reset()
+        m2.reset()
 
 
 @pytest.mark.parametrize(

torchmetrics/collections.py

@@ -169,6 +169,9 @@ def update(self, *args: Any, **kwargs: Any) -> None:
                 # only update the first member
                 m0 = getattr(self, cg[0])
                 m0.update(*args, **m0._filter_kwargs(**kwargs))
+                for i in range(1, len(cg)):  # copy over the update count
+                    mi = getattr(self, cg[i])
+                    mi._update_count = m0._update_count
         else:  # the first update always do per metric to form compute groups
             for _, m in self.items(keep_base=True):
                 m_kwargs = m._filter_kwargs(**kwargs)