Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch bfloat import version #9089

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Fix torch bfloat import version #9089

merged 3 commits into from
Aug 24, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 24, 2021

What does this PR do?

Create a separate check for bfloat as current check does not allow people who use nightly to use bfloat precision.

Related #9049

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the feature Is an improvement or enhancement label Aug 24, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 24, 2021
@SeanNaren SeanNaren self-assigned this Aug 24, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #9089 (56745b6) into master (81145ca) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9089    +/-   ##
=======================================
+ Coverage      88%     92%    +4%     
=======================================
  Files         178     178            
  Lines       14694   14695     +1     
=======================================
+ Hits        12917   13527   +610     
+ Misses       1777    1168   -609     

@SeanNaren SeanNaren enabled auto-merge (squash) August 24, 2021 14:55
@SeanNaren SeanNaren disabled auto-merge August 24, 2021 17:11
@SeanNaren SeanNaren enabled auto-merge (squash) August 24, 2021 17:12
@SeanNaren SeanNaren merged commit 1bab0a1 into master Aug 24, 2021
@SeanNaren SeanNaren deleted the fix/imports branch August 24, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants