Remove extra param in Docs from metric Precision #5520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlielito
requested review from
ananyahjha93,
justusschock and
teddykoker
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5520 +/- ##
=======================================
- Coverage 93% 93% -1%
=======================================
Files 135 152 +17
Lines 10007 10736 +729
=======================================
+ Hits 9341 9948 +607
- Misses 666 788 +122 |
Borda
approved these changes
Jan 15, 2021
|
@SkafteNicki so you suggest closing this one just let it merge as a small bugfix... |
|
@Borda yes, change target to master and let it pass as a bugfix (I would say that we usually let pure doc fixes pass directly to master) |
Borda
requested review from
awaelchli,
edenlightning,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
I guess duplicate #5532? close one of them |
In the docs there is `beta` param, which does not correspond to any param of `Precision`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs there is
betaparam, which does not correspond to any param ofPrecision.