-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create accumulator element (for loss) directly on the device #12430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly on the device
isvogor-foi
requested review from
williamFalcon,
Borda,
tchaton,
SeanNaren,
carmocca,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
March 23, 2022 21:47
carmocca
reviewed
Mar 24, 2022
carmocca
approved these changes
Mar 24, 2022
rohitgr7
approved these changes
Mar 24, 2022
Co-authored-by: Rohit Gupta <[email protected]>
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Mar 25, 2022
rohitgr7
changed the title
Modified so that in the accumulator element (for loss) is created di…
Create accumulator element (for loss) directly on the device
Mar 25, 2022
kaushikb11
approved these changes
Mar 25, 2022
@carmocca is it possible to trigger the ci-tests again? Looks like some pip dependency error was raised, which is unrelated to this PR. Build infrastructure hickup? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rectly on the device
What does this PR do?
Fixes #12408
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃