Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create accumulator element (for loss) directly on the device #12430

Merged
merged 7 commits into from
Mar 25, 2022

Conversation

isvogor-foi
Copy link
Contributor

@isvogor-foi isvogor-foi commented Mar 23, 2022

…rectly on the device

What does this PR do?

Fixes #12408

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.6 milestone Mar 24, 2022
pytorch_lightning/trainer/supporters.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 25, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 25, 2022
@rohitgr7 rohitgr7 changed the title Modified so that in the accumulator element (for loss) is created di… Create accumulator element (for loss) directly on the device Mar 25, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) March 25, 2022 09:06
@isvogor-foi
Copy link
Contributor Author

@carmocca is it possible to trigger the ci-tests again? Looks like some pip dependency error was raised, which is unrelated to this PR. Build infrastructure hickup?

@carmocca carmocca disabled auto-merge March 25, 2022 10:37
@carmocca carmocca merged commit 25b771c into Lightning-AI:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this a bug? - unnecessary CPU/GPU copying in supporters.py just for aggregating loss
4 participants