Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation warnings from core/hooks #9337

Closed
rohitgr7 opened this issue Sep 5, 2021 · 0 comments · Fixed by #9279
Closed

Remove deprecation warnings from core/hooks #9337

rohitgr7 opened this issue Sep 5, 2021 · 0 comments · Fixed by #9279
Labels
feature Is an improvement or enhancement help wanted Open to be worked on refactor

Comments

@rohitgr7
Copy link
Contributor

rohitgr7 commented Sep 5, 2021

Proposed refactoring or deprecation

Do we need these warnings here? https://github.com/PyTorchLightning/pytorch-lightning/blob/cf1a589956f86a0cf1a50c0710051eee9b082094/pytorch_lightning/core/hooks.py#L694-L733

They just come up even when we don't override them.

We already have them here: https://github.com/PyTorchLightning/pytorch-lightning/blob/cf1a589956f86a0cf1a50c0710051eee9b082094/pytorch_lightning/trainer/configuration_validator.py#L83-L95

Motivation

Remove them. Warnings in the docs are enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on refactor
Projects
None yet
Milestone
No milestone
1 participant
@rohitgr7