Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Remaining tasks for Strategy stable version #11812

Closed
four4fish opened this issue Feb 8, 2022 · 2 comments
Closed

[Tracker] Remaining tasks for Strategy stable version #11812

four4fish opened this issue Feb 8, 2022 · 2 comments
Labels
accelerator feature Is an improvement or enhancement strategy trainer: connector won't fix This will not be worked on

Comments

@four4fish
Copy link
Contributor

four4fish commented Feb 8, 2022

🚀 Feature

Lightning Strategy stable version

Motivation

After the refactoring issue is done, the main code structure will be stable. But there are other correctness and stability related issues that need to be addressed, some API simplification should be done, and some P0 features should be supported.

Pitch

Remaining tasks

  1. Finish refactor, we have two remaining steps for accelerator refactor
  2. Correctness and stability related issues
  3. API simplifications and improvement
    • Deprecations : unused properties in accl_conn, enums, trainer.X_method
    • Align DDP/DDPSpawn process creation Interface for Process Creation (DDPSpawn vs. DDP) #10985
    • Precision API revisit, better support amp, move misconfig/availability checks from accl_conn to precision.init_
    • Strategies API revisit, add is_distributed(), and move misconfig/availability checks to strategy.init
    • Accelerator API revisit, add teardown(), and add devices availability check (in review)
    • Finish collective refactor
  4. Feature support
  5. Better engineering tasks
    • Improve typing
    • Improve unit tests
    • docs and docstrings

Alternatives

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @Borda @justusschock @kaushikb11 @awaelchli @ninginthecloud @akihironitta @rohitgr7 @carmocca @tchaton @ananthsub

@four4fish four4fish added the feature Is an improvement or enhancement label Feb 8, 2022
@four4fish four4fish added this to the 1.6 milestone Feb 8, 2022
@carmocca
Copy link
Contributor

This kind of issue is more of a "Tracker" than an "RFC" so renaming it a such if you don't mind :)

@carmocca carmocca changed the title [Main Issue] [RFC] Remaining tasks for Strategy stable version [Tracker] Remaining tasks for Strategy stable version Feb 28, 2022
@Borda Borda modified the milestones: 1.6, 1.6.x Mar 21, 2022
@carmocca carmocca removed this from the 1.6.x milestone Mar 22, 2022
@stale
Copy link

stale bot commented Apr 24, 2022

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Apr 24, 2022
@stale stale bot closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator feature Is an improvement or enhancement strategy trainer: connector won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants