Avoid overwriting the lightning_app entry point (#20041)

* don't overwrite lightning_app entry point * bump version * trigger ci
Lightning-AI · Jul 4, 2024 · 056bb08 · 056bb08
1 parent 8b69285
commit 056bb08
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci-pkg-install.yml b/.github/workflows/ci-pkg-install.yml
@@ -73,13 +73,14 @@ jobs:
           pkg-extra: ${{ matrix.pkg-extra }}
 
       - name: Run CLI (via python)
-        if: ${{ (matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') && matrix.pkg-extra == 'app' }}
+        if: ${{ (matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') }}
         run: python -m lightning --version
+
       - name: Run CLI (direct bash)
         if: |
-          ((matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') && matrix.pkg-extra == 'app') ||
+          ((matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') ||
           matrix.pkg-name == 'app'
-        run: lightning_app --version
+        run: lightning --version
 
       - name: DocTests actions
         working-directory: .actions/

diff --git a/src/lightning/__setup__.py b/src/lightning/__setup__.py
@@ -114,7 +114,6 @@ def _setup_args() -> Dict[str, Any]:
             "console_scripts": [
                 "fabric = lightning.fabric.cli:_main",
                 "lightning = lightning.fabric.cli:_legacy_main",
-                "lightning_app = lightning:_cli_entry_point",
             ],
         },
         "setup_requires": [],

diff --git a/src/lightning/fabric/CHANGELOG.md b/src/lightning/fabric/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 
+
 ## [2.3.0] - 2024-06-13
 
 ### Added

diff --git a/src/version.info b/src/version.info
@@ -1 +1 @@
-2.3.1
+2.3.2
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
		The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).



		## [2.3.0] - 2024-06-13

		### Added
Expand Down