Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Deprecated compute_on_step from Classification #962

Merged

Conversation

tanmoyio
Copy link
Contributor

@tanmoyio tanmoyio commented Apr 16, 2022

What does this PR do?

Part of #956 - classification

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tanmoyio tanmoyio changed the title Removed Deprecated from Classification Removed Deprecated compute_on_step from Classification Apr 16, 2022
@Borda Borda added the refactoring refactoring and code health label Apr 16, 2022
@Borda Borda added this to the v0.9 milestone Apr 16, 2022
@Borda Borda mentioned this pull request Apr 16, 2022
9 tasks
@Borda Borda enabled auto-merge (squash) April 16, 2022 14:04
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #962 (5756a3a) into master (439d205) will increase coverage by 17%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #962     +/-   ##
=======================================
+ Coverage      70%    87%    +17%     
=======================================
  Files         177    177             
  Lines        7509   7509             
=======================================
+ Hits         5290   6533   +1243     
+ Misses       2219    976   -1243     

@mergify mergify bot added the ready label Apr 16, 2022
@Borda Borda merged commit 1a62754 into Lightning-AI:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants