-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric retrieval recall at precision #951
Metric retrieval recall at precision #951
Conversation
for more information, see https://pre-commit.ci
@MrShevan, how is it going here? 🐰 |
Hi! Sorry was busy at the end of the week, I keep working on PR. I'm still thinking about my implementation. Was it right to inherit from |
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 177 179 +2
Lines 7522 7631 +109
======================================
+ Hits 7148 7229 +81
- Misses 374 402 +28 |
09a8cad
to
e0ea387
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
….com/MrShevan/metrics into metric_retrieval_recall_at_precision
for more information, see https://pre-commit.ci
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
….com/MrShevan/metrics into metric_retrieval_recall_at_precision
for more information, see https://pre-commit.ci
@stancld @Borda @SkafteNicki
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Borda @stancld @SkafteNicki |
great contribution! |
@MrShevan Thanks a lot for your great contribution! :) |
What does this PR do?
Hello, @stancld ! It's a draft PR for issue: Fixes #780
I still think about how to add more tests, testing pattern in this repo is pretty hard, but the general idea of
RetrievalRecallAtFixedPrecision
is implemented.Keep working 🛠
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃