-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added micro average option for torch metrics #874
added micro average option for torch metrics #874
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=======================================
+ Coverage 71% 86% +15%
=======================================
Files 181 181
Lines 7993 8004 +11
=======================================
+ Hits 5681 6895 +1214
+ Misses 2312 1109 -1203 |
@Borda Please have a look. After initial review, I will remove all the commented-out lines, but there might be some incompatibility related issues since I was going to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation-wise it looks good to me. Just not sure how to proceed with different arguments for different metrics. IMO it should all be called reduction
, but not sure how to handle different arguments. Will we have separate helper functions or just one function that does it all and some others just for input validation?
@razmikmelikbekyan how is it going here? 🐰 |
@Borda Honestly said I am a bit confused about the next steps. I am not sure that I will have enough time right now to refactor all the other metrics and so on and I do not understand what exactly needs to be done in this particular PR. Should we merge it or we want to change name back to reduction and so one (in my opinion name average_type is more relevant and adapted by the community for this kind of metrics than reduction) |
@stancld mind help with this PR? :) |
Hey @razmikmelikbekyan , Very sorry for the long return time. The decisions made offline with @Borda and @SkafteNicki were that we want to get this to merge now and that we will deal with the naming inconsistencies while doing the major refactor (#1001 ). |
hey @justusschock, yep, I will have a look soon. |
for more information, see https://pre-commit.ci
What does this PR do?
Added Micro average option for IoU.
Fixes #826
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃