Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved shape checking of permutation_invariant_training #864

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Improved shape checking of permutation_invariant_training #864

merged 4 commits into from
Feb 28, 2022

Conversation

quancs
Copy link
Member

@quancs quancs commented Feb 27, 2022

What does this PR do?

Fixes #859

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #864 (449c509) into master (9f94086) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #864   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         167    167           
  Lines        6931   6931           
=====================================
- Hits         6587   6575   -12     
- Misses        344    356   +12     

@quancs quancs marked this pull request as ready for review February 27, 2022 17:52
@SkafteNicki SkafteNicki added the enhancement New feature or request label Feb 28, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Feb 28, 2022
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

@SkafteNicki SkafteNicki enabled auto-merge (squash) February 28, 2022 09:45
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Feb 28, 2022
@SkafteNicki SkafteNicki merged commit ffe824a into Lightning-AI:master Feb 28, 2022
@quancs quancs deleted the fix-pit-2 branch February 28, 2022 13:27
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check shape
3 participants