-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune deprecated: classification and regression #806
Conversation
* Remove deprecated functions, and warnings * Update links for docstring * chlog Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
=====================================
+ Coverage 95% 95% +1%
=====================================
Files 165 163 -2
Lines 6776 6710 -66
=====================================
- Hits 6410 6384 -26
+ Misses 366 326 -40 |
Failing integration test for |
Pull Request is not mergeable
@SkafteNicki seems we have the same issue with PL compatibility here too, as so shall we break the compatibility with PL |
@Borda this is a though one, but I am in favour of breaking backwards-compatibility with lightning. We need first and foremost to think of metrics as its own package which does not depend on lightning. In practise I do not know how many actually uses metrics with base torch and how many uses it with lightning. |
we have this testing already inside EcoCI - https://github.com/PyTorchLightning/ecosystem-ci/blob/main/configs/PyTorchLightning/metrics_pl-develop.yaml |
+1 for this approach |
@Borda: Any updates on the final approach for this issue? |
it is going to merge as soon as all test passes :) |
What does this PR do?
Fixes part of #771
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃