-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify r/fbeta/fbeta_score #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuent
requested review from
ananyahjha93,
Borda,
edenlightning,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
January 10, 2022 21:37
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 169 169
Lines 6718 6725 +7
=====================================
+ Hits 6382 6387 +5
- Misses 336 338 +2 |
12 tasks
Borda
reviewed
Jan 10, 2022
Borda
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😃 Some suggestions
Co-authored-by: Ethan Harris <[email protected]>
ethanwharris
approved these changes
Jan 11, 2022
facebook-github-bot
pushed a commit
to facebookresearch/recipes
that referenced
this pull request
Mar 14, 2022
Summary: ### New commit log messages - [d36fffc Unify r/fbeta/fbeta_score (#740)](Lightning-AI/torchmetrics#740) Reviewed By: tangbinh Differential Revision: D34814343 fbshipit-source-id: 572d856caf110ab383e2766db93b47a5e2597b69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unify r/fbeta/fbeta_score - part of #729
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃