rename hinge to hinge_loss
#734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getgaurav2
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
approved these changes
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
======================================
+ Coverage 91% 95% +4%
======================================
Files 167 167
Lines 6582 6591 +9
======================================
+ Hits 5990 6266 +276
+ Misses 592 325 -267 |
* [WIP] Add MS-SSIM * Fix docs and a mypy issue * fix badge * Apply some SkafteNicki's suggestions from code review * Fix docstring: MS_SSIM -> MultiScaleSSIM * Fix missed MS_SSIM in a docstring * flake8 * Add tests * Update doc example * Fix seed for doc + update some tests * Clean code * Update doc example + make diff test tractable * torch.manual seed passed directly to torch.rand * Apply suggestions from code review * Drop some tests ; fix docs issues + add missing docs * Update paper.md (Lightning-AI#690) * ci: rename oldest * CI: set HF caching (Lightning-AI#691) * Apply suggestions: ms_ssim -> multiscale_ssim + typing * Update doc reference * Apply SkafteNicki's suggestions * Update test reference package * Clean test * Change naming multiscale_ssim -> multiscale_structual_similarity_index_measure * Update docs references * Fix a typo: structual -> structural * fix one last typo * Fix ~ len in a doc Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Maxim Grechkin <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
SkafteNicki
approved these changes
Jan 10, 2022
Borda
force-pushed
the
master
branch
2 times, most recently
from
1432b77 to
6c3668d
Compare
stancld
approved these changes
Jan 10, 2022
12 tasks
Borda
added a commit
that referenced
this pull request
Jan 10, 2022
* change hinge to hinge_loss * HingeLoss Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #729
hingetohinge_lossBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃