-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify f1 score #731
unify f1 score #731
Conversation
Should |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
- Coverage 95% 73% -22%
=======================================
Files 166 166
Lines 6483 6494 +11
=======================================
- Hits 6174 4759 -1415
- Misses 309 1735 +1426 |
Yes, please use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- deprecation warnings & back compatibility
- rename also
F1
class to be consistent (suggestionF1Score
) - add changelog
part of #729
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecation warnings & back-compatibility, see #731 (review)
2a32b9c
to
ab68b55
Compare
for more information, see https://pre-commit.ci
* f1_score * F1Score Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: Daniel Stancl <[email protected]>
What does this PR do?
Refactor F1 score
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃