Unify preds, target input arguments for text metrics [1of2] bert, bleu, chrf, sacre_bleu, wip, wil
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancld
added
enhancement
stancld
changed the title
preds, target input arguments for text metrics 1/2preds, target input arguments for text metrics 1/2 + nits
stancld
changed the title
preds, target input arguments for text metrics 1/2 + nitspreds, target input arguments for text metrics 1/2
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 170 170
Lines 6759 6769 +10
=====================================
+ Hits 6398 6408 +10
Misses 361 361 |
Borda
changed the title
preds, target input arguments for text metrics 1/2preds, target input arguments for text metrics [6of12]
|
@stancld made the metrics as a checkbox also here so you can check progress and could you also update the original issue? |
12 tasks
|
still WIP? 🐰 |
Yes a bit, I'll need to handle breaking changes add some deprecation warnings as you pointed out in #727 |
Borda
requested changes
Jan 8, 2022
Currently adding these... Though, still thinking about if we shouldn't go with |
stancld
requested review from
ananyahjha93,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
Borda
reviewed
Jan 9, 2022
Borda
force-pushed
the
master
branch
3 times, most recently
from
3a0f7dc to
317182c
Compare
Borda
reviewed
Jan 10, 2022
Borda
reviewed
Jan 11, 2022
Borda
reviewed
Jan 11, 2022
Borda
reviewed
Jan 11, 2022
Borda
reviewed
Jan 12, 2022
Borda
reviewed
Jan 12, 2022
Borda
reviewed
Jan 12, 2022
Borda
approved these changes
Jan 12, 2022
SkafteNicki
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR unifies
preds, targetinput arguments fortext metrics+ also unifies some minor related stuffPart of #716
Fixes:
bertbleuchrfsacre_bleuwipwilBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃