Fix bool sort on CUDA #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 166 166
Lines 6369 6370 +1
=====================================
+ Hits 6062 6065 +3
+ Misses 307 305 -2 |
twsl
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
justusschock
approved these changes
Dec 8, 2021
SkafteNicki
approved these changes
Dec 8, 2021
Borda
reviewed
Dec 8, 2021
Borda
approved these changes
Dec 8, 2021
Borda
pushed a commit
that referenced
this pull request
Dec 12, 2021
* Fix bool sort on CUDA * Add dedicated gpu test * Apply suggestions from code review Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit e98fbaf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #664
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃