Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #638

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Remove deprecated code #638

merged 6 commits into from
Nov 25, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 24, 2021

What does this PR do?

Remove code deprecated in 0.6.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #638 (bb3afdf) into master (3aef7be) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #638   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         160    159    -1     
  Lines        5605   5584   -21     
=====================================
- Hits         5334   5315   -19     
+ Misses        271    269    -2     

@mergify mergify bot added the ready label Nov 24, 2021
@Borda Borda enabled auto-merge (squash) November 25, 2021 10:28
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in the changelog add lines that these arguments were removed... similar to earlier we wrote that they were deprecated

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit f9db019 into master Nov 25, 2021
@Borda Borda deleted the remove0.7 branch November 25, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants