Torch-based mAP #632
Merged
Torch-based mAP #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool! Thanks for porting that. |
twsl
commented
Nov 22, 2021
|
Is that correct, that there are two scores while only one prediction @tkupek? |
obviously a bug, you can remove the second score |
tkupek
reviewed
Nov 22, 2021
tkupek
reviewed
Nov 22, 2021
tkupek
reviewed
Nov 22, 2021
tkupek
reviewed
Nov 22, 2021
tkupek
reviewed
Nov 22, 2021
Co-authored-by: Tobias Kupek <[email protected]>
Co-authored-by: Tobias Kupek <[email protected]>
|
@twsl over all it looks Great! mind checking the last failing test for new PT versions: |
Borda
reviewed
Dec 4, 2021
Borda
approved these changes
Dec 4, 2021
Borda
reviewed
Dec 4, 2021
Borda
pushed a commit
that referenced
this pull request
Dec 5, 2021
* First draft * Remove double score * Calculate num_class only * Support empty predictions * Remove pycocotools from tests * Fix annotation id evals to false if zero * Improve method descriptions * Fix returning metrics if parameters are changed * Apply suggestions from code review Co-authored-by: Tobias Kupek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2494e68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #587
Simply converted the pycocotools source code to pytorch and torchvision instead of numpy.
The rest in based on @tkupek work.
I plan to rename the file as soon as I know that it's working, right now I still need both for comparison.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃