MAP metric - fix empty predictions #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkupek
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 150 150
Lines 5308 5308
=====================================
- Hits 5050 5048 -2
- Misses 258 260 +2 |
SkafteNicki
approved these changes
Oct 29, 2021
Borda
reviewed
Oct 29, 2021
Borda
reviewed
Oct 29, 2021
Borda
approved these changes
Oct 29, 2021
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in the MAP detection metric, which crashes if the predictions are an empty list.
I added a test for this case and fixes the issue in the metric.