Add missing higher_is_better attribute to metrics
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 148 148
Lines 5111 5142 +31
=====================================
+ Hits 4866 4895 +29
- Misses 245 247 +2 |
Borda
approved these changes
Oct 27, 2021
justusschock
approved these changes
Oct 27, 2021
Co-authored-by: Justus Schock <[email protected]>
|
@tchaton you do not need to merge master, it is done automatically by bot... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
I could swear that I have already added this attribute to all these metrics, but apparently it is not present in a lot of our metrics.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃