Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LPIPS #431

Merged
merged 44 commits into from
Aug 18, 2021
Merged

add LPIPS #431

merged 44 commits into from
Aug 18, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 6, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #427
Adds LPIPS metric to image package. Use to measure perceptual similarity.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #431 (f2804d5) into master (00f0256) will decrease coverage by 0.11%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   95.97%   95.85%   -0.12%     
==========================================
  Files         129      130       +1     
  Lines        4227     4274      +47     
==========================================
+ Hits         4057     4097      +40     
- Misses        170      177       +7     
Flag Coverage Δ
Linux 75.03% <83.33%> (+0.08%) ⬆️
Windows 75.03% <83.33%> (+0.08%) ⬆️
cpu 75.03% <83.33%> (-20.92%) ⬇️
gpu 95.85% <91.66%> (-0.05%) ⬇️
macOS 75.03% <83.33%> (-20.92%) ⬇️
pytest 95.85% <91.66%> (-0.12%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/image/lpip_similarity.py 91.11% <91.11%> (ø)
torchmetrics/__init__.py 100.00% <100.00%> (ø)
torchmetrics/image/__init__.py 100.00% <100.00%> (ø)
torchmetrics/utilities/imports.py 83.33% <100.00%> (+0.40%) ⬆️
torchmetrics/average.py 84.61% <0.00%> (-11.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f0256...f2804d5. Read the comment docs.

@SkafteNicki SkafteNicki marked this pull request as ready for review August 6, 2021 13:13
@Borda Borda changed the title [New metric] LPIPS add LPIPS Aug 6, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
tests/image/test_lpips.py Outdated Show resolved Hide resolved
torchmetrics/image/lpip_similarity.py Outdated Show resolved Hide resolved
@Borda Borda added this to the v0.6 milestone Aug 8, 2021
@pep8speaks
Copy link

pep8speaks commented Aug 8, 2021

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-09 11:30:34 UTC

@mergify mergify bot removed the has conflicts label Aug 16, 2021
@mergify mergify bot removed the has conflicts label Aug 17, 2021
@mergify mergify bot added the ready label Aug 17, 2021
@mergify mergify bot removed the ready label Aug 18, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) August 18, 2021 07:21
@SkafteNicki SkafteNicki merged commit db281f7 into master Aug 18, 2021
@SkafteNicki SkafteNicki deleted the lpips branch August 18, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LPIPS is requested for some low-level CV problem
4 participants