-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Rouge score #399
add Rouge score #399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 96.45% 96.05% -0.40%
==========================================
Files 120 122 +2
Lines 3804 3900 +96
==========================================
+ Hits 3669 3746 +77
- Misses 135 154 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rather use only rouge_score
only for testing and have our own implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some initial comments
The import errors will be gone after #383 is merged and |
@karthikrangasai how is it going? the mentioned PR has been merged... 🐰 |
I have updated the dependencies but the |
5b2bf71
to
8027712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, final set of comments :]
…or, update doc strings
@karthikrangasai mind add typing? (mypy is failing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow that's a very old feature request <3
I mainly looked over the docs, very nice!
Before submitting
What does this PR do?
Fixes #51 .
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃