-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multilabel for AveragePrecision #386
multilabel for AveragePrecision #386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
===========================================
+ Coverage 76.68% 96.29% +19.60%
===========================================
Files 118 118
Lines 3719 3722 +3
===========================================
+ Hits 2852 3584 +732
+ Misses 867 138 -729
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6d7b761
to
64ace03
Compare
for more information, see https://pre-commit.ci
torchmetrics/functional/classification/precision_recall_curve.py
Outdated
Show resolved
Hide resolved
Hello @discort! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-24 19:56:51 UTC |
torchmetrics/functional/classification/precision_recall_curve.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
it compiled without errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, but could we try to fit this testcase inside the already established testing framework?
Head branch was pushed to by a user without write access
@SkafteNicki mind revisit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :]
Before submitting
What does this PR do?
Fixes #359
PR review
@Borda @SkafteNicki
Did you have fun?
⚡⚡⚡