-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weighted AUROC to omit empty classes #376
Conversation
added logic to omit empty classes with weighted AUROC, as they should have 0 weight anyway
Hello @BeyondTheProof! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-24 21:07:30 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 96.37% 96.39% +0.01%
==========================================
Files 120 120
Lines 3756 3771 +15
==========================================
+ Hits 3620 3635 +15
Misses 136 136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BeyondTheProof mind check the failing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, remember to also update the changelog as this influences the end user!
for more information, see https://pre-commit.ci
Now checks for ValueError and UserWarning
for more information, see https://pre-commit.ci
@SkafteNicki I've addressed all your suggestions, and my tests are passing locally. However, code coverage is failing, but I don't know how to address this, and whether it is important or not in this scenario. I would appreciate this workflow approved to make sure everything is A-OK! Thanks again. |
@BeyondTheProof do not worry about the code coverage. Only test to focus on are the once marked as "required" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :]
Before submitting
What does this PR do?
Fixes #348.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃