-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning & prune re-definine #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
ananyahjha93,
justusschock,
SkafteNicki and
tchaton
as code owners
July 13, 2021 21:22
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 96.44% 96.42% -0.02%
==========================================
Files 112 112
Lines 3655 3665 +10
==========================================
+ Hits 3525 3534 +9
- Misses 130 131 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
commented
Jul 13, 2021
awaelchli
approved these changes
Jul 14, 2021
Borda
commented
Jul 14, 2021
justusschock
approved these changes
Jul 14, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Breaking Changes:
r2score
>>r2_score
andkldivergence
>>kl_divergence
intorchmetrics.functional
.What does this PR do?
normalise some functional metrics names to be consistent
prune some redefinition
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃