Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning & prune re-definine #371

Merged
merged 5 commits into from
Jul 14, 2021
Merged

cleaning & prune re-definine #371

merged 5 commits into from
Jul 14, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 13, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • Does this PR contains any breaking changes ? Yes
  • Does this PR provides user warning for depreciation ! Yes !

Breaking Changes:

  • Rename r2score >> r2_score and kldivergence >> kl_divergence in torchmetrics.functional.

What does this PR do?

normalise some functional metrics names to be consistent
prune some redefinition

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jul 13, 2021
@Borda Borda added this to the v0.5 milestone Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #371 (382a57f) into master (7c9b572) will decrease coverage by 0.01%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   96.44%   96.42%   -0.02%     
==========================================
  Files         112      112              
  Lines        3655     3665      +10     
==========================================
+ Hits         3525     3534       +9     
- Misses        130      131       +1     
Flag Coverage Δ
Linux 76.39% <89.74%> (+<0.01%) ⬆️
Windows 76.39% <89.74%> (+<0.01%) ⬆️
cpu 95.66% <97.43%> (-0.73%) ⬇️
gpu 96.34% <97.43%> (-0.02%) ⬇️
macOS 95.66% <97.43%> (-0.73%) ⬇️
pytest 96.42% <97.43%> (-0.02%) ⬇️
python3.6 ?
python3.8 95.60% <97.43%> (-0.79%) ⬇️
python3.9 ?
torch1.3.1 ?
torch1.4.0 95.60% <97.43%> (-0.02%) ⬇️
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/kl_divergence.py 87.87% <ø> (ø)
torchmetrics/functional/classification/accuracy.py 92.95% <0.00%> (-1.33%) ⬇️
torchmetrics/retrieval/mean_average_precision.py 100.00% <ø> (ø)
...hmetrics/classification/binned_precision_recall.py 100.00% <100.00%> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/classification/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/classification/auc.py 90.62% <100.00%> (ø)
...metrics/functional/classification/kl_divergence.py 90.62% <100.00%> (+1.33%) ⬆️
torchmetrics/functional/regression/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/regression/psnr.py 96.96% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9b572...382a57f. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda added the ready label Jul 14, 2021
@Borda Borda enabled auto-merge (squash) July 14, 2021 14:54
@Borda Borda merged commit a4d2a7a into master Jul 14, 2021
@Borda Borda deleted the prune/re-def branch July 14, 2021 15:39
@Borda Borda mentioned this pull request Jul 16, 2021
4 tasks
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants