-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow threshold to be outside (0,1) domain #351
Conversation
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-07 07:46:44 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 96.44% 96.44% -0.01%
==========================================
Files 112 112
Lines 3659 3657 -2
==========================================
- Hits 3529 3527 -2
Misses 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Before submitting
What does this PR do?
Fixes #350
Removes the requirement that
threshold
needs to be in the (0,1) domain which should have been removed with PR #200PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃