Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow threshold to be outside (0,1) domain #351

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Allow threshold to be outside (0,1) domain #351

merged 5 commits into from
Jul 7, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 6, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #350
Removes the requirement that threshold needs to be in the (0,1) domain which should have been removed with PR #200

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jul 6, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 6, 2021

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-07 07:46:44 UTC

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #351 (fc0e98f) into master (b20cbda) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   96.44%   96.44%   -0.01%     
==========================================
  Files         112      112              
  Lines        3659     3657       -2     
==========================================
- Hits         3529     3527       -2     
  Misses        130      130              
Flag Coverage Δ
Linux 76.37% <ø> (+0.01%) ⬆️
Windows 76.37% <ø> (+0.01%) ⬆️
cpu 96.39% <ø> (-0.01%) ⬇️
gpu 96.36% <ø> (-0.01%) ⬇️
macOS 96.39% <ø> (-0.01%) ⬇️
pytest 96.44% <ø> (-0.01%) ⬇️
python3.6 95.54% <ø> (-0.01%) ⬇️
python3.8 96.39% <ø> (+0.10%) ⬆️
python3.9 96.28% <ø> (?)
torch1.3.1 95.54% <ø> (-0.01%) ⬇️
torch1.4.0 95.62% <ø> (?)
torch1.9.0 96.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/stat_scores.py 98.30% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20cbda...fc0e98f. Read the comment docs.

@Borda Borda added the documentation Improvements or additions to documentation label Jul 6, 2021
@Borda Borda added the ready label Jul 6, 2021
@mergify mergify bot added the has conflicts label Jul 7, 2021
@mergify mergify bot removed the has conflicts label Jul 7, 2021
@Borda Borda merged commit 0495776 into master Jul 7, 2021
@Borda Borda deleted the fix_threshold branch July 7, 2021 08:32
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logits and multilabel: Add support for threshold <= 0?
3 participants