Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: regression #333

Merged
merged 8 commits into from
Jun 30, 2021
Merged

typing: regression #333

merged 8 commits into from
Jun 30, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 30, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #333 (42d0da3) into master (8412701) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   75.88%   75.93%   +0.04%     
==========================================
  Files         111      111              
  Lines        3562     3569       +7     
==========================================
+ Hits         2703     2710       +7     
  Misses        859      859              
Flag Coverage Δ
Linux 75.93% <100.00%> (+0.04%) ⬆️
Windows 75.93% <100.00%> (+0.04%) ⬆️
cpu 75.93% <100.00%> (+0.04%) ⬆️
macOS 75.93% <100.00%> (+0.04%) ⬆️
pytest 75.93% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/image/psnr.py 79.16% <100.00%> (+0.90%) ⬆️
torchmetrics/image/ssim.py 100.00% <100.00%> (ø)
torchmetrics/regression/cosine_similarity.py 95.65% <100.00%> (ø)
torchmetrics/regression/explained_variance.py 94.11% <100.00%> (+1.01%) ⬆️
torchmetrics/regression/mean_absolute_error.py 94.73% <100.00%> (ø)
...trics/regression/mean_absolute_percentage_error.py 94.73% <100.00%> (ø)
torchmetrics/regression/mean_squared_error.py 95.00% <100.00%> (ø)
torchmetrics/regression/mean_squared_log_error.py 94.73% <100.00%> (ø)
torchmetrics/regression/pearson.py 95.83% <100.00%> (ø)
torchmetrics/regression/r2score.py 90.32% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8412701...42d0da3. Read the comment docs.

@Borda
Copy link
Member Author

Borda commented Jun 30, 2021

the same also here, most of the mypy issues are about

error: Signature of "update" incompatible with supertype "Metric"  [override]

@Borda Borda marked this pull request as ready for review June 30, 2021 10:01
@Borda Borda changed the title typing regression typing: regression Jun 30, 2021
@mergify mergify bot removed the has conflicts label Jun 30, 2021
@Borda Borda self-assigned this Jun 30, 2021
@Borda Borda added the enhancement New feature or request label Jun 30, 2021
@Borda Borda requested a review from justusschock June 30, 2021 13:23
@mergify mergify bot removed the has conflicts label Jun 30, 2021
@Borda Borda merged commit 877244e into master Jun 30, 2021
@Borda Borda deleted the typing/reg branch June 30, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants