Refactor: typing #330
Merged
Refactor: typing #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
enhancement
for more information, see https://pre-commit.ci
…/metrics into refactor/typing
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
- Coverage 96.59% 96.54% -0.05%
==========================================
Files 111 111
Lines 3552 3559 +7
==========================================
+ Hits 3431 3436 +5
- Misses 121 123 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-30 07:27:56 UTC |
for more information, see https://pre-commit.ci
…/metrics into refactor/typing
for more information, see https://pre-commit.ci
…/metrics into refactor/typing
Borda
commented
Jun 29, 2021
|
@SkafteNicki @justusschock any idea why the differentiability tests are failing? Cannot reproduce it locally 😕 |
maximsch2
reviewed
Jun 29, 2021
SkafteNicki
approved these changes
Jun 30, 2021
| @@ -40,7 +40,7 @@ def _explained_variance_compute( | |||
| sum_target: Tensor, | |||
| sum_squared_target: Tensor, | |||
| multioutput: str = "uniform_average", | |||
| ) -> Union[Tensor, Sequence[Tensor]]: | |||
| ) -> Tensor: | |||
There was a problem hiding this comment.
This does not seem correct to me. Even when setting multioutput='raw_values it is still a single tensor that is returned
There was a problem hiding this comment.
we return the Tensor now or am I missing anything?
Co-authored-by: Nicki Skafte <[email protected]>
maximsch2
reviewed
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃