-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace thredshold argument to binned metrics #322
Conversation
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-28 21:35:21 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
===========================================
- Coverage 96.54% 75.71% -20.84%
===========================================
Files 111 111
Lines 3536 3541 +5
===========================================
- Hits 3414 2681 -733
- Misses 122 860 +738
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: Adrian Wälchli <[email protected]>
Awesome, thanks for improving this! |
Before submitting
What does this PR do?
Fixes #265
Adds
threshold
argument to binned metrics for manually control which thresholds to usecc: @maximsch2
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃