Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added differentiability for metrics - 4/n #253

Merged
merged 12 commits into from
Jun 8, 2021

Conversation

bhadreshpsavani
Copy link
Contributor

Checklist

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

@SkafteNicki

@Borda Borda marked this pull request as draft May 16, 2021 10:13
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #253 (de97eaa) into master (5d6b0ce) will decrease coverage by 0.04%.
The diff coverage is 83.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   87.95%   87.91%   -0.05%     
==========================================
  Files         184      184              
  Lines        6020     6090      +70     
==========================================
+ Hits         5295     5354      +59     
- Misses        725      736      +11     
Flag Coverage Δ
Linux 78.92% <83.11%> (-0.13%) ⬇️
cpu 78.92% <83.11%> (-0.13%) ⬇️
gpu 96.88% <ø> (+0.03%) ⬆️
pytest 87.91% <83.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/confusion_matrix.py 95.83% <66.66%> (-4.17%) ⬇️
torchmetrics/classification/f_beta.py 92.00% <66.66%> (-3.46%) ⬇️
torchmetrics/classification/hamming_distance.py 90.90% <66.66%> (-3.83%) ⬇️
torchmetrics/classification/hinge.py 90.90% <66.66%> (-3.83%) ⬇️
torchmetrics/classification/iou.py 93.75% <66.66%> (-6.25%) ⬇️
torchmetrics/classification/matthews_corrcoef.py 94.73% <66.66%> (-5.27%) ⬇️
torchmetrics/classification/precision_recall.py 88.88% <66.66%> (-4.45%) ⬇️
...chmetrics/classification/precision_recall_curve.py 96.42% <66.66%> (-3.58%) ⬇️
torchmetrics/classification/roc.py 96.29% <66.66%> (-3.71%) ⬇️
torchmetrics/classification/stat_scores.py 77.10% <66.66%> (-0.40%) ⬇️
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6b0ce...de97eaa. Read the comment docs.

@SkafteNicki SkafteNicki changed the title [WIP] added differentiability for metrics - 4/n Added differentiability for metrics - 4/n May 31, 2021
@SkafteNicki SkafteNicki marked this pull request as ready for review May 31, 2021 09:12
@SkafteNicki
Copy link
Member

Hi @bhadreshpsavani,
I pushed some changed to your PR that should resolve the failing tests. Please take a look before I go ahead and approve :]

@SkafteNicki SkafteNicki added the enhancement New feature or request label May 31, 2021
@SkafteNicki SkafteNicki added this to the v0.4 milestone May 31, 2021
@bhadreshpsavani
Copy link
Contributor Author

Hi @SkafteNicki,
Thanks for fixing the issues! I have gone through the changes.

@Borda Borda enabled auto-merge (squash) June 3, 2021 21:41
@Borda
Copy link
Member

Borda commented Jun 3, 2021

@bhadreshpsavani mind check failing tests?
cc: @PyTorchLightning/core-metrics

@Borda Borda merged commit 6f0ef3b into Lightning-AI:master Jun 8, 2021
@bhadreshpsavani bhadreshpsavani deleted the differentiablity-4 branch June 9, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants