Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auroc error message #244

Merged
merged 4 commits into from
May 13, 2021
Merged

Auroc error message #244

merged 4 commits into from
May 13, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 12, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #234
Adds better error message for AUROC when evaluation multi class but does not provide the num_classes argument.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label May 12, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #244 (0b42ad7) into master (078671f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   96.82%   96.80%   -0.02%     
==========================================
  Files         184       92      -92     
  Lines        6010     3007    -3003     
==========================================
- Hits         5819     2911    -2908     
+ Misses        191       96      -95     
Flag Coverage Δ
Linux 79.08% <50.00%> (-0.02%) ⬇️
Windows 79.08% <50.00%> (-0.02%) ⬇️
cpu 96.80% <100.00%> (+<0.01%) ⬆️
gpu ?
macOS 96.80% <100.00%> (+<0.01%) ⬆️
pytest 96.80% <100.00%> (-0.02%) ⬇️
python3.6 95.74% <100.00%> (+<0.01%) ⬆️
python3.8 96.80% <100.00%> (+<0.01%) ⬆️
python3.9 96.70% <100.00%> (+<0.01%) ⬆️
torch1.3.1 95.74% <100.00%> (+<0.01%) ⬆️
torch1.4.0 95.87% <100.00%> (+<0.01%) ⬆️
torch1.8.1 96.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/classification/auroc.py 86.56% <100.00%> (+0.41%) ⬆️
...cs/functional/regression/mean_squared_log_error.py
__w/1/s/torchmetrics/classification/stat_scores.py
__w/1/s/torchmetrics/retrieval/retrieval_ndcg.py
__w/1/s/torchmetrics/retrieval/__init__.py
.../s/torchmetrics/classification/confusion_matrix.py
__w/1/s/torchmetrics/utilities/prints.py
__w/1/s/torchmetrics/setup_tools.py
__w/1/s/torchmetrics/retrieval/retrieval_metric.py
...chmetrics/classification/precision_recall_curve.py
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078671f...0b42ad7. Read the comment docs.

@Borda Borda enabled auto-merge (squash) May 12, 2021 11:27
@Borda Borda added the ready label May 12, 2021
@mergify mergify bot removed the has conflicts label May 12, 2021
@Borda Borda merged commit a21eec5 into master May 13, 2021
@Borda Borda deleted the auroc_error_message branch May 13, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUROC metric errors lead to confusing error messages
3 participants