Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AUROC to take advantage of known order ahead of time #230

Merged
merged 3 commits into from
May 6, 2021

Conversation

maximsch2
Copy link
Contributor

@maximsch2 maximsch2 commented May 5, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #219 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #230 (2701930) into master (33864db) will decrease coverage by 0.49%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   96.80%   96.31%   -0.50%     
==========================================
  Files         184      184              
  Lines        6010     5997      -13     
==========================================
- Hits         5818     5776      -42     
- Misses        192      221      +29     
Flag Coverage Δ
Linux 79.09% <87.50%> (+0.02%) ⬆️
Windows 79.09% <87.50%> (+0.02%) ⬆️
cpu 95.81% <87.50%> (-0.99%) ⬇️
gpu 96.80% <ø> (+<0.01%) ⬆️
macOS 95.81% <87.50%> (-0.99%) ⬇️
pytest 96.31% <87.50%> (-0.50%) ⬇️
python3.6 95.75% <87.50%> (+<0.01%) ⬆️
python3.8 ?
python3.9 ?
torch1.3.1 95.75% <87.50%> (+<0.01%) ⬆️
torch1.4.0 ?
torch1.8.1 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/classification/auroc.py 66.15% <75.00%> (-20.00%) ⬇️
torchmetrics/functional/classification/auc.py 88.88% <100.00%> (+1.38%) ⬆️
torchmetrics/classification/auroc.py 87.50% <0.00%> (-5.19%) ⬇️
torchmetrics/metric.py 90.84% <0.00%> (-4.66%) ⬇️
torchmetrics/wrappers/bootstrapping.py 86.20% <0.00%> (-1.73%) ⬇️
torchmetrics/regression/r2score.py 93.33% <0.00%> (-0.22%) ⬇️
torchmetrics/regression/explained_variance.py 96.42% <0.00%> (-0.13%) ⬇️
torchmetrics/classification/accuracy.py 96.07% <0.00%> (-0.08%) ⬇️
torchmetrics/utilities/prints.py 100.00% <0.00%> (ø)
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33864db...2701930. Read the comment docs.

@SkafteNicki SkafteNicki added ready bug / fix Something isn't working labels May 6, 2021
@SkafteNicki SkafteNicki added this to the v0.4 milestone May 6, 2021
@Borda Borda enabled auto-merge (squash) May 6, 2021 08:37
@Borda Borda merged commit 05c45a5 into Lightning-AI:master May 6, 2021
@maximsch2 maximsch2 deleted the auc_reorder branch May 6, 2021 16:26
Borda pushed a commit that referenced this pull request May 10, 2021
* Fix AUROC to take advantage of known order ahead of time

* changelog

Co-authored-by: Nicki Skafte <[email protected]>
(cherry picked from commit 05c45a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants