-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loads metric states from state_dict #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm - @SkafteNicki what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Nicki Skafte <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 96.65% 88.22% -8.44%
==========================================
Files 180 180
Lines 5738 5740 +2
==========================================
- Hits 5546 5064 -482
- Misses 192 676 +484
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The persistent metric states are output in
state_dict
, but cannot be properly loaded throughload_state_dict()
. This PR adds handling to loading persisted metric states fromstate_dict
and a unit test.