Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports: deprecate from pkg root [4/n] Retrieval #1699

Merged
merged 11 commits into from
Apr 11, 2023
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 7, 2023

What does this PR do?

Part of #1681 (comment)

  • class version
  • functional
  • tests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda marked this pull request as ready for review April 11, 2023 11:56
@Borda Borda requested a review from a team April 11, 2023 11:56
@Borda Borda enabled auto-merge (squash) April 11, 2023 12:14
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1699 (1edbe5c) into master (1056c26) will decrease coverage by 50%.
The diff coverage is 71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1699     +/-   ##
========================================
- Coverage      89%     38%    -50%     
========================================
  Files         232     234      +2     
  Lines       12983   13084    +101     
========================================
- Hits        11494    4985   -6509     
- Misses       1489    8099   +6610     

@mergify mergify bot removed the has conflicts label Apr 11, 2023
@mergify mergify bot requested a review from a team April 11, 2023 13:39
@mergify mergify bot removed the has conflicts label Apr 11, 2023
@Borda Borda merged commit c4b605f into master Apr 11, 2023
@Borda Borda deleted the imports/retrieval branch April 11, 2023 20:42
@Borda Borda added the refactoring refactoring and code health label Apr 11, 2023
@Borda Borda added this to the v1.0.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants