Feature/modified panoptic quality #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctests
marcocaccin
requested review from
edenlightning,
SkafteNicki,
Borda and
justusschock
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
========================================
- Coverage 89% 39% -50%
========================================
Files 226 228 +2
Lines 12220 12287 +67
========================================
- Hits 10815 4744 -6071
- Misses 1405 7543 +6138 |
Borda
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #1591
Before submitting
PR review
Adds Modified Panoptic Quality as a separate metric, heavily borrowing common functionalities from the original implementation.
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃