Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify usage of metric tracker #1608

Merged
merged 6 commits into from
Mar 11, 2023
Merged

Specify usage of metric tracker #1608

merged 6 commits into from
Mar 11, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1409
Metric tracker supports single Metric and MetricCollection. This PR adds support for other MetricWrappers.
Additionally, warnings will be raised instead of failing if multi nested structures such as:

MetricCollection(MultiOutput(MeanSquaredError()))

where the output structures of the computed result gets too complicated/specific to process further.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 10, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1608 (bce8dc8) into master (78e9571) will decrease coverage by 50%.
The diff coverage is 95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1608     +/-   ##
========================================
- Coverage      88%     39%    -50%     
========================================
  Files         226     226             
  Lines       12029   12039     +10     
========================================
- Hits        10632    4668   -5964     
- Misses       1397    7371   +5974     

@Borda Borda requested a review from a team March 10, 2023 20:12
@mergify mergify bot added ready and removed has conflicts labels Mar 10, 2023
@mergify mergify bot removed the ready label Mar 10, 2023
@mergify mergify bot added the ready label Mar 11, 2023
@Borda Borda merged commit 3f74920 into master Mar 11, 2023
@Borda Borda deleted the metric_tracker branch March 11, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MetricTracker of MultioutputWrapper
3 participants