Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner case for R2Score #1576

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fix corner case for R2Score #1576

merged 2 commits into from
Mar 1, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 1, 2023

What does this PR do?

Fixes #1573

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 1, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1576 (28b8bd8) into master (f9514c0) will decrease coverage by 50%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1576     +/-   ##
========================================
- Coverage      88%     38%    -50%     
========================================
  Files         223     223             
  Lines       11656   11661      +5     
========================================
- Hits        10310    4488   -5822     
- Misses       1346    7173   +5827     

@Borda Borda enabled auto-merge (squash) March 1, 2023 15:27
@mergify mergify bot added the ready label Mar 1, 2023
@mergify mergify bot requested a review from a team March 1, 2023 15:27
@Borda Borda merged commit 17e0890 into master Mar 1, 2023
@Borda Borda deleted the bugfix/r2_score branch March 1, 2023 22:50
Borda pushed a commit that referenced this pull request Mar 10, 2023
(cherry picked from commit 17e0890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r2_score larger than 1 with (near) constant target
3 participants