Adding support for plot() in image metrics
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
11 tasks
|
What is done: What is remaining: |
venomouscyanide
changed the title
venomouscyanide
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
Borda
approved these changes
Feb 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1480 +/- ##
======================================
- Coverage 89% 88% -0%
======================================
Files 216 216
Lines 11275 11331 +56
======================================
+ Hits 9993 10022 +29
- Misses 1282 1309 +27 |
justusschock
approved these changes
Feb 17, 2023
for more information, see https://pre-commit.ci
SkafteNicki
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1406.
What is done:
(1) SpectralDistortionIndex
(2) ErrorRelativeGlobalDimensionlessSynthesis
(3) PeakSignalNoiseRatio
(4) SpectralAngleMapper
(5) StructuralSimilarityIndexMeasure and MultiScaleStructuralSimilarityIndexMeasure
(6) UniversalImageQualityIndex
What is remaining:
(1) FrechetInceptionDistance
(2) InceptionScore
(3) KernelInceptionDistance
(4) LearnedPerceptualImagePatchSimilarity
(5) TotalVariation
My blocker currently is all the above modules not having ‘preds’ and ‘targets’ like the others when calling metric.update(preds, target) . Any help is greatly appreciated.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃