Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multilabel in exact_match #1474

Merged
merged 14 commits into from
Feb 6, 2023
Merged

fix multilabel in exact_match #1474

merged 14 commits into from
Feb 6, 2023

Conversation

7shoe
Copy link
Contributor

@7shoe 7shoe commented Feb 2, 2023

Typo in line 235. Changed multilalbe to multilabel.

What does this PR do?

Small typo for argument task for the exact_match metric.
Identify multi-label classification task properly by changing multilalbe to multilabel.

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos [THIS] and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs? (None required, just ypo)
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yes.

Make sure you had fun coding 🙃

Typo in line 235. Changed `multilalbe` to `multilalbe`.
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1474 (044a825) into master (0e16392) will decrease coverage by 38%.
The diff coverage is 0%.

❗ Current head 044a825 differs from pull request most recent head a9b6553. Consider uploading reports for the commit a9b6553 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1474     +/-   ##
========================================
- Coverage      90%     51%    -38%     
========================================
  Files         213     213             
  Lines       10921   10921             
========================================
- Hits         9793    5618   -4175     
- Misses       1128    5303   +4175     

@Borda Borda changed the title Update exact_match.py fix multilabel in exact_match Feb 2, 2023
@Borda Borda added the bug / fix Something isn't working label Feb 2, 2023
@mergify mergify bot added the ready label Feb 2, 2023
@Borda Borda enabled auto-merge (squash) February 2, 2023 11:23
Borda and others added 2 commits February 3, 2023 14:24
…[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]>

* gh: update templates

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mergify mergify bot added ready and removed ready labels Feb 3, 2023
@mergify mergify bot added the ready label Feb 5, 2023
@mergify mergify bot removed the ready label Feb 6, 2023
.azure/gpu-pipeline.yml Outdated Show resolved Hide resolved
@Borda Borda disabled auto-merge February 6, 2023 12:18
@Borda Borda merged commit 91ac6fe into Lightning-AI:master Feb 6, 2023
Borda pushed a commit that referenced this pull request Feb 20, 2023
* Update exact_match.py
* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit 91ac6fe)
Borda pushed a commit that referenced this pull request Feb 20, 2023
* Update exact_match.py
* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit 91ac6fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants