-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multilabel
in exact_match
#1474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo in line 235. Changed `multilalbe` to `multilalbe`.
7shoe
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
February 2, 2023 00:50
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1474 +/- ##
========================================
- Coverage 90% 51% -38%
========================================
Files 213 213
Lines 10921 10921
========================================
- Hits 9793 5618 -4175
- Misses 1128 5303 +4175 |
Borda
approved these changes
Feb 2, 2023
justusschock
approved these changes
Feb 2, 2023
stancld
approved these changes
Feb 2, 2023
stancld
reviewed
Feb 2, 2023
SkafteNicki
approved these changes
Feb 3, 2023
…[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> * gh: update templates --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
reviewed
Feb 6, 2023
Borda
approved these changes
Feb 6, 2023
3 tasks
Borda
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Update exact_match.py * Apply suggestions from code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 91ac6fe)
Borda
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Update exact_match.py * Apply suggestions from code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 91ac6fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in line 235. Changed
multilalbe
tomultilabel
.What does this PR do?
Small typo for argument
task
for theexact_match
metric.Identify multi-label classification task properly by changing
multilalbe
tomultilabel
.Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes.
Make sure you had fun coding 🙃