Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocast in SSIM metric #1454

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Fix autocast in SSIM metric #1454

merged 6 commits into from
Jan 27, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 23, 2023

What does this PR do?

Fixes #1453
Exchange ValueError with explicit dtype casting to support mixed precision autocast

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jan 23, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1454 (6e7cb97) into master (662a2a2) will decrease coverage by 51%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1454     +/-   ##
========================================
- Coverage      90%     39%    -51%     
========================================
  Files         211     211             
  Lines       10839   10839             
========================================
- Hits         9718    4228   -5490     
- Misses       1121    6611   +5490     

@Borda Borda enabled auto-merge (squash) January 24, 2023 17:55
@mergify mergify bot added the ready label Jan 24, 2023
@Borda Borda merged commit 3d0c392 into master Jan 27, 2023
@Borda Borda deleted the bugfix/autocast_ssim branch January 27, 2023 11:44
Borda pushed a commit that referenced this pull request Jan 30, 2023
(cherry picked from commit 3d0c392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change targets.dtype to the type of outputs in the intern of StructuralSimilarityIndexMeasure().update()?
3 participants