-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exception for invalid kwargs in Metric base class #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPronovost
requested review from
SkafteNicki,
justusschock,
Borda,
tchaton and
ethanwharris
as code owners
January 4, 2023 21:00
EPronovost
changed the title
Raise exception for invalid kwargs
Raise exception for invalid kwargs in Metric base class
Jan 4, 2023
Borda
approved these changes
Jan 5, 2023
Borda
requested changes
Jan 5, 2023
SkafteNicki
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the integration.
The integration test had the exact problem mentioned in the issue.
Borda
approved these changes
Jan 9, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
======================================
Coverage 90% 90%
======================================
Files 211 211
Lines 10846 10849 +3
======================================
+ Hits 9716 9719 +3
Misses 1130 1130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1426
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃