Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds indexing operation to Metric class #142

Merged
merged 9 commits into from
Mar 29, 2021

Conversation

victorjoos
Copy link
Contributor

@victorjoos victorjoos commented Mar 29, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #132 (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@victorjoos victorjoos marked this pull request as ready for review March 29, 2021 07:16
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #142 (407136e) into master (b7312a2) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   79.29%   79.26%   -0.03%     
==========================================
  Files          78       78              
  Lines        2405     2407       +2     
==========================================
+ Hits         1907     1908       +1     
- Misses        498      499       +1     
Flag Coverage Δ
Linux 79.26% <55.55%> (-0.03%) ⬇️
Windows 79.26% <55.55%> (-0.03%) ⬇️
cpu 79.26% <55.55%> (-0.03%) ⬇️
macOS 79.26% <55.55%> (-0.03%) ⬇️
pytest 79.26% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/metric.py 55.21% <50.00%> (-0.05%) ⬇️
torchmetrics/wrappers/bootstrapping.py 79.31% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7312a2...407136e. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Mar 29, 2021

Hello @victorjoos! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-29 11:54:13 UTC

@Borda Borda added the enhancement New feature or request label Mar 29, 2021
tests/bases/test_composition.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
@Borda Borda added the ready label Mar 29, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) March 29, 2021 11:54
@SkafteNicki SkafteNicki merged commit a4bc98c into Lightning-AI:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement __getitem__ as "metric arithmetic"
4 participants