-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper multilabel support for confmat #134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 96.76% 96.77%
=======================================
Files 156 156
Lines 4826 4837 +11
=======================================
+ Hits 4670 4681 +11
Misses 156 156
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just not sure about the is_multilabel
sound unnatural to me... (as an argument, it would be fine as property or attribute)
@Borda I have changed the arg to just |
Before submitting
What does this PR do?
Fixes #100
Currently using confusion matrix with multilabel data will smash it all together as one big binary classification problem, which is really not wanted. Instead we should probably go for something similar to what sklearn does in that case (https://scikit-learn.org/stable/modules/generated/sklearn.metrics.multilabel_confusion_matrix.html). Instead of having a specialized metric for this case, this PR adds a
is_multilabel
flag and implements the same logic as sklearn.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃