-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleaning after classification refactor 1/n #1251
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
========================================
- Coverage 86% 49% -36%
========================================
Files 195 190 -5
Lines 11378 11108 -270
========================================
- Hits 9754 5480 -4274
- Misses 1624 5628 +4004 |
not sure why make docs complains about types :( |
Docs were failing because I had removed this file https://github.com/Lightning-AI/metrics/blob/eacfd2fcd4521fb3c69bcb53e5b1be9117c8a163/docs/source/pages/classification.rst and not all the links to that file. The info in that file is old and in the two follow up PRs I will redo the docstrings of all the old metrics so it matches the new interface. |
What does this PR do?
Cleaning after the classification refactor.
This PR cleans metrics that were directly removed, move to other domain or included in some other metric.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃