Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning after classification refactor 1/n #1251

Merged
merged 26 commits into from
Oct 12, 2022
Merged

Code cleaning after classification refactor 1/n #1251

merged 26 commits into from
Oct 12, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 5, 2022

What does this PR do?

Cleaning after the classification refactor.
This PR cleans metrics that were directly removed, move to other domain or included in some other metric.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the refactoring refactoring and code health label Oct 5, 2022
@SkafteNicki SkafteNicki added this to the v0.10 milestone Oct 5, 2022
@Borda Borda modified the milestones: v0.10, v0.11 Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1251 (c35620f) into master (eacfd2f) will decrease coverage by 36%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1251     +/-   ##
========================================
- Coverage      86%     49%    -36%     
========================================
  Files         195     190      -5     
  Lines       11378   11108    -270     
========================================
- Hits         9754    5480   -4274     
- Misses       1624    5628   +4004     

@mergify mergify bot removed the has conflicts label Oct 6, 2022
@Borda Borda enabled auto-merge (squash) October 6, 2022 16:22
@mergify mergify bot added the has conflicts label Oct 8, 2022
@mergify mergify bot removed the has conflicts label Oct 8, 2022
src/torchmetrics/__init__.py Show resolved Hide resolved
src/torchmetrics/__init__.py Show resolved Hide resolved
src/torchmetrics/__init__.py Show resolved Hide resolved
src/torchmetrics/__init__.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready label Oct 11, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Oct 12, 2022
@Borda
Copy link
Member

Borda commented Oct 12, 2022

not sure why make docs complains about types :(

@SkafteNicki
Copy link
Member Author

not sure why make docs complains about types :(

Docs were failing because I had removed this file https://github.com/Lightning-AI/metrics/blob/eacfd2fcd4521fb3c69bcb53e5b1be9117c8a163/docs/source/pages/classification.rst and not all the links to that file.
Should be fixed now.

The info in that file is old and in the two follow up PRs I will redo the docstrings of all the old metrics so it matches the new interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants