Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved efficiency of all module retrieval metrics #1242

Merged
merged 10 commits into from
Sep 29, 2022
Merged

improved efficiency of all module retrieval metrics #1242

merged 10 commits into from
Sep 29, 2022

Conversation

lucadiliello
Copy link
Contributor

@lucadiliello lucadiliello commented Sep 27, 2022

What does this PR do?

Fixes #1241

On CPU, it improves performance of every modular retrieval metric by 5x. I didn't measure improvements on GPU, if someone can, please do it.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs? No API changes
  • Did you write any new necessary tests? No new metrics

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1242 (74a184f) into master (199e6cc) will not change coverage.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1242   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files         193     193           
  Lines       11375   11375           
======================================
  Hits         9757    9757           
  Misses       1618    1618           

@mergify mergify bot added the ready label Sep 28, 2022
@lucadiliello
Copy link
Contributor Author

I do not know how to solve the error with python 3.10 on mac. Any clues?

@SkafteNicki
Copy link
Member

I do not know how to solve the error with python 3.10 on mac. Any clues?

Lets try to re-run and see if it was an one-off error

@SkafteNicki SkafteNicki enabled auto-merge (squash) September 29, 2022 10:24
@SkafteNicki SkafteNicki merged commit 3bf1491 into Lightning-AI:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve modular retrieval metrics efficiency
3 participants