-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved efficiency of all module retrieval metrics #1242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucadiliello
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
September 27, 2022 20:54
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
======================================
Coverage 86% 86%
======================================
Files 193 193
Lines 11375 11375
======================================
Hits 9757 9757
Misses 1618 1618 |
justusschock
approved these changes
Sep 28, 2022
SkafteNicki
reviewed
Sep 28, 2022
I do not know how to solve the error with python 3.10 on mac. Any clues? |
SkafteNicki
approved these changes
Sep 29, 2022
Lets try to re-run and see if it was an one-off error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1241
On CPU, it improves performance of every modular retrieval metric by 5x. I didn't measure improvements on GPU, if someone can, please do it.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃