-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix state reference in MetricCollection
#1076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
- Coverage 95% 90% -4%
=======================================
Files 181 181
Lines 8085 8103 +18
=======================================
- Hits 7654 7315 -339
- Misses 431 788 +357 |
SkafteNicki
requested review from
justusschock,
Borda,
tchaton,
ethanwharris and
SeanNaren
as code owners
June 8, 2022 16:55
Borda
approved these changes
Jun 8, 2022
justusschock
approved these changes
Jun 8, 2022
…thub.com/PyTorchLightning/metrics into bugfix/state_reference_metric_collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1051
When users call
.items()
,.values
or__getitem__
on a metric collection that have enabled compute groups, the metric states are currently only by referenced, leading to weird results sometimes when metrics in the collection is individually interacted with (as when logging in PL withself.log
).PR fixes this by creating copies (instead of references) when needed.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃